Prison Documents - Table of Contents
These build logs represent the work that has been going on within prison.
Prison supports:
Spigot 1.8 through 1.18, and other platforms based upon Spigot.
Many updates and bug fixes. Please see the change log for all of them. Below is just a limited summary of some of the more important updates.
Asynchronous mine reset enablement
Prison can now be disabled completely on a per world basis. See setting in config.yml.
If the server is missing an economy plugin, prison now does a better job at communicating what the problem is so it can be fixed quickly. An economy plugin is required for the ranks module to function.
Added a debug mode for inspecting a block. To enable, enable prison debug with /prison debug then while holding a prison wand /mines wand click a block and it will show a couple of lines tied to the information that prison has recorded for that block. If you shift-right click a block, then prison will check each event listener to see what it does with the block. It will report when a block event is canceled and other details, on a per listener basis.
Start to add tokens to prison. Players can now earn tokens while mining. Its a work in progress, but they cannot spend them yet.
Updated block constraints so blocks can be spawned in specific layers within a mine, and with a minimum or maximum amounts.
Placeholders - Prison now has 258 placeholders, including aliases. Added many placeholders and improve a few that were having some issues. There are still more that are planned to be added.
Added new Prison Mine Bombs - Work in progress - Basics exist and have a lot of functionality, but more work will be done to add new features and address issues when found and reported. If you have ideas, or need something specific, please visit our discord server and talk to Blue.
Coming Soon: Mine Region. Mine effects that are applied to Mine Regions. Mine Effects will include potion effects like night vision, and other effects such as no hunger, no fall damage, and fly. Also may be adding enchantments soon too.
Significant improvements for handling multi-block explosions with a major rewrite to improve the overall performance within the handling of block break events within the auto features. Many changes to improve performance on a per-block basis, and to prevent a block from being counted more than once when many different players are trying to break, or explode the same blocks.
NOTE: It is currently recommended that the old Prison Backpacks should not be used at this time. They will be rewritten shortly to address the current issues.
Added to SpigotPlayer the ability to enable flying and to check to see if the player is flying. This is to prepare for mine effects.
Considering adding heads support to prison. Added a few parts, but they are not functional.
3.2.11-alpha.17 2022-01-18
More updates to the player’s rank menu with the ability to add rank specific lore to the configs. When referring to ranks, the names much match exactly since they are case sensitive.
Bug fix with the rank cost calculations since they were not pulling in the last rank in the rang of ranks.
Fixed an issue with CI’s function that was not returning any ids.
Mine auto resets can now be disabled. When disabled, they will never reset based upon time. The resets can still be triggered by blocks remaining thresholds.
3.2.11-alpha.16 2022-01-16
Lot of updates to the GUI menus. Major improvements to the player’s /gui ranks to work better with placeholders. Added comments to the GuiConfig.yml file on how to use it and the placeholders. Delete the GuiConfig.yml file to regenerate with the updated information on lore settings.
Update a few of the player’s GUIs to support the SpigotGUIMenutools. Added capability to control the return command and the paging command so it now works more intuitivily.
Fix issue with the placeholders related to prison_rankup_cost. This now works correctly to include the next prestig rank’s cost when at the last rank in the default ladder.
Bug fix: Get the 32 placeholders related to prison_rankup_cost working correctly when dealing with various prestige conditions.
**Bug fix: The player based playSound was not working, but the world’s playSound works perfectly. Not sue why bukkit player would be messed up that **
Bug fix: Hooking up the rollover to the next prestige rank cost, when at th end of the ladder, had a typo where it would not evaluate any rank.
3.2.11-alpha.15 2022-01-13
Bug Fix: If the wrong sound file was being used it used to throw a NPE. Now this is a safer way to find the correct file, and it will fall back upon a plink sound for any version of spigot.
If upon loading a mine, there is a reson or need to resave the data, since this is an auto update, then this will make a backup copy of the mine’s save file before saving it.
Bug fix: If spigot version is less than 1.13.0, and trying to use a _WOOD block, XMaterials cannot map that correctly to a Material and then back to the same XMaterial. This is causing a problem when using in a mine since it cannot be tied back to the block that was placed. So for these versions, all _WOOD blocks are removed from the server. If a _WOOD block is saved in a mine, it will be remapped to the same _PLANKS block, which will work just fine.
Bug fix: Prevent stack traces when a broken block cannot be mapped to a PrisonBlockStatusData object. This is happening with spigot versions 1.8 through 1.12.2 when using “WOOD” blocks since XSeries translates these blocks to LOGs, so they will never map back to the XMaterial WOOD entries. This was producing a stacktrace and would prevent the proper handling of the auto features.
3.2.11-alpha.14 2022-01-11
Update the failed rank message so it is clearer.
When a player is on the default ladder at the last possible rank, instead of showing nothing for rankup costs, percent, bar, etc, it will now use the next prestige rank if prestiges are enabled.
These changes apply to the following placeholders:
prison_rc prison_rankup_cost prison_rc_laddername prison_rankup_cost_laddername prison_rcf prison_rankup_cost_formatted prison_rcf_laddername prison_rankup_cost_formatted_laddername prison_rcp prison_rankup_cost_percent prison_rcp_laddername prison_rankup_cost_percent_laddername prison_rcb prison_rankup_cost_bar prison_rcb_laddername prison_rankup_cost_bar_laddername prison_rcr prison_rankup_cost_remaining prison_rcr_laddername prison_rankup_cost_remaining_laddername prison_rcrf prison_rankup_cost_remaining_formatted prison_rcrf_laddername prison_rankup_cost_remaining_formatted_laddername prison_rcrp prison_rankup_cost_remaining_percent prison_rcrp_laddername prison_rankup_cost_remaining_percent_laddername prison_rcrb prison_rankup_cost_remaining_bar prison_rcrb_laddername prison_rankup_cost_remaining_bar_laddername
On delayed startup, allow a combination of selectors to target essentials, since the class name has changed in v2.19.x
Setup the block inspector to auto select a diamond shovel, a diamond axe, or a diamond pickaxe.
On the blockbreak debug information, show the information on either the block that was hit, or if that is null, just dashes to show such a block was not provided.
For EssentialsX v2.19.x, the class being used to identify if the economy has been loaded has changed. This commit has the references to the proper class to use depeending upon the version of EssentialsX. It should be noted that this only applies if delayed startup is enabled for the EssentialsX economy, which generally does not require it.
Change in how prison deals with ranks when there isn’t an economy plugin loaded.
Now, instead of printing a simple little message in the console, which everyone appear to miss, it also enables a generic /ranks command that only displays a message indicating that no economy was found, with links to documentation. This should make it more obvious.
Change to auto features for the event listeners: now MONITOR is not enabled unless set to priority of MONITOR.
If a language file has a message that is set to an empty string or a space, it will now no longer generate an empty message. Instead it will supress the sending of any message that is blank.
Move the placeholder prison_player_blocks_total from being a player mine placeholder, to a player placeholder since it is not tied to a specific mine.
Added a formatted version (with commas) and this one became unformatted so it can be used within scripts if needed.
The use of the /ranks command remove within the /ranks info, or /ranks command list was not correctly including the correct row number; it was using one higher than what it should have due to prior incrementing.
Issues with SellAll when dealing with varient block types when bukkit version is less than 1.13. Eliminate usage of org.bukkit.Material where possible. XMaterial must generate the ItemStack directly, instead of creating a Material object.
Fix some issues with canceling drops: Will not work on 1.8.x and maybe a few other versions of spigot with no work arounds. Works on newer versions.
New Feature: Dump the BlockBreakEvent and monitor changes per listener.
This provides a great deal of information on what is modifying the blocks.
To use, enter prison debug mode with /prison debug and then shift-click on a block using the prison wand (/mines wand).
Bug Fix: When loading the mines, and if using the old block model, some blocks were not mapping to the new PrisonBlocks. When this now happens, the loader now tries to use the old block model’s getXMaterialName() function, which returns one or more names that can map to XMaterial objects. It tries all of them until it is able to get a non-null PrisonBlock result.
Added a safty backup of the player’s cache file… if it is detected that the new size is smaller than the prior size, then make a backup copy saving the original version instead of deleting it. This implies that stats will always be added to the player’s cache and that the file should alwaysbe getting larger. This only makes sense when recording stats. The file could become smaller when balances are reset, such as spending a lot of tokens. This also implies that some times, such as player inventories, should not be stored in this object… player’s backpacks will be removed in the near future. It should be mentioned that on a test server I saw my player stats for my test player being wipped out. I have no idea if it was because of file system commands that I ran, or if it was a bug in prison that reset it. But because there was a potential loss, I’m making sure certain things cannot happen anymore, or trying to reduce the risk of losses.
Fix the sellall block list gui for when there is an invalid XMaterial name, that it will print out the error to the console, and continue with using COBBLESTONE instead of producing a NPE.
For the list of displaying the ranks on a ladder, split them up to show 15 per line which will help when there are a lot of ranks on a given ladder.
Increased the confirmation on mine size from 25,000 to 50,000 blocks so as to minimize the number of times this will occur.
Add support for specifying the sound to use for inventory full event. Valid sounds can be listed with the command /prison utils sounds list.
Added support for doubles in the AutoFeatures settings. The basics were there, but the actual AutoFeatures enum did not have them hooked up.
Remove an unused function on the PlayerCache.
Bug fix for mohist, or other platforms that are trying to use SuperPerms, or other perm plugins that do not support groups.
Add all to the command /mines set tpAccessByRank.
Add ‘all’ as an option for applying Access by Rank for mines command: /mines set mineAccessByRank.
3.2.11-alpha.13 2021-12-24
Prison command handler: adds the ability to add new aliases from the config file.
For ranks that are null, made some changes so either empty strings are used instad, or most of the time the rank name is used.
Fixed a potential issue with nulls in the language file parameters. All nulls are replaced with empty strings.
Added the ability for admins to add aliases to commands so they can better customize their environment.
Disable block break events in the worlds where prison commands are disabled.
Added the ability to disable prison command hander is specific worlds. The settings are within config.yml. The disabling of prison is only done on the command handler, and will soon be hooked up to the block break events too. The command /prison now lists worlds in which prison has been disabled
3.2.11-alpha.12 2021-12-21 Alpha 12 released.
Fixed issue with XMaterial when trying to parse a custom blcok that is not compatible with prison. The function will now return a null value and everything that uses it, must ensure it’s not null before trying to use it.
Make sure the targetBlock is not null before trying to process it.
Docs: Updated the LuckPerms Tracks and Groups document to provide more details on how to set them up.
Bug fix: Ran in to a rare situation where the use of essentialsX economy failed to allow prison to load the players during startup. Prison was trying to “rank” the players within each rank that they were in, and that required prison to get their balance…. but bukkit was not able to return an OfflinePlayer instance for any of the plyers. Therefore prison could not access the player through vault. No idea why bukkit is not able to provide the players. The server in question had about 2500 players. So to prevent this from happening, the initial ranking bypasses the loading of any monetary amounts; they will be updated later.
Update and create some new LuckPerms docs.
Move gui tools menu changes to improve them and hook them up to menus that did not have any paging.
Adjustments to improve the way the new gui tools work to reduce the amount of use of lore, or at least the visible lore. This visually cleans it up a lot.
Hooked up some of the new features to the /gui ranks menu, plus added a /gui ladders and hooked that up. Simplified how the ladders page was setup.
More work on the GUI menu tools to not only get them to work better (correctly) but also add new capabilities… now supports adding a menu option and the tool auto assigns it to the next available slot.
GUI menu tools update…
Prison Tokens: Remove the alias so they will not cause conflict with other token plugins.
Potential bug fix: There was a situation where with multiverse-core a delayed world loading resulted in the world not being found, and therefore it was preventing the loading of all locations tied to the mine. This now allows the locations to be loaded without a valid world. Then when the world is finally loaded, it will refresh the references to the world objects.
GUI Menu: a few minor changes before more radical changes to go with the final “idea”.
GUI Menu Tools - Added a first page and last page button.
GUI Bug fix: If there are more than 45 ranks on a ladder, the GUI will NOW be able to provide paging capabilities to view all ranks. By default it will start off with page one, but this can handle an unlimited number of pages. This paging system can be expanded and easily used on other GUI lists with minimal changes to hook it up.
Found a bug in XMaterial where it was converting “melon” to melon_slice instead of the melon block.
Bug fix: Fixed an incorrect use of XMaterial which prevented it from working properly with spigot 1.8 through 1.12. It was using XMaterial to get the Material value, which is wrong, since it’s the item stack that contains the variants of the materials. So the change is to extract the item stack directly from XMaterial which solves the problem. Also there was another error where if amounts are greater than 64, setting them to 1 so the GUI will still work, but it will suppress the incorrect counts for the itemstack.
Update XSeries to v8.5.0.1 to better support spigot 1.18.
Prison tokens: Add a few more prison tokens placeholders. Fixed the admin token commands to use longs and not integers.
Ranks GUI Error. Fixed an error with Ranks GUI. This did not fix anything.
Some adjustments to admin token functions.
Bug fix: Rankup on a ladder in which there is not already a rank was producing an error. Similar to prior problem… just did not fix it correctly for all situations.
Start building the structure for the Top N rankings.
Mine Bombs: Noticed the player inventory was not be “updated” through bukkit. This could help prevent wrong item amounts.
Mine Bombs: Set them up to auto refresh the data structure that is being saved, if it is detected that there has been a change. Added a version number to the mine bomb save data structure so as to use that to detect when the structure changes. That number will be updated in code when it has been modified. So when running the mine bomb loader, it will detect that the saved data is in an older format, and so it will rename the old file to preserve it as a backup, then write the new data to the file system. This will allow new fields to be added,and then they will appear in the save file upon the next restart. This will make it easier for admins to update and use the new features.
Bug fix: Was causing a null pointer exception when trying to add a player to a new ladder. This now correctly gives the player the requested rank, or if not specified, then the lowest rank on that ladder.
3.2.11-alpha.11 2021-12-07
Mine Bombs: A few other minor fixes and changes.
Mine Bombs: Some changes in how they are setup. Added a bombItemId which becomes line one of the lore and is used to identify that it’s a mine bomb. Added a nameTag that is used to put a nameTag on the armor stand. Added a itemRemovalDelayTicks field to better control when the armor stand is removed (exact time). Update a lot of Mine Bomb code for creating the time, placing the item (armor stand) etc… It’s working better overall.
Update Tokens to fix an issue with the admin set. Added better tracking of adminAdded and adminRemoved stats.
Bug fix: Fixed a class not found except caused by google guava trying to load functions that it should not have been using for their event manager. Moved the PEE event out of this class all together, so now it’s safe to use in other areas of prison, such as with guava’s event handler. This was not an issue with spigot 1.8.8, but manifested itself with Spigot 1.16.5 since I believe that version of spigot is using a newer version of guava that has that behavior.
Upgrade XSeries to v8.5.0
3.2.11-alpha.10 2021-12-05
Bug fix: There was an issue that I found where blocks outside of the explosion events were being marked as mined without actually being broken. Therefore prison would not be able to break those blocks. This was caused by the initial explosion setting off a chained reaction explosion through a blockEvent. Now blocks that are part of an explosion cannot be part of a future explosion.
Added a new debug mode to inspect blocks by click on them with the mine wand tool when prison is in debug mode.
Renamed Prison’s PlayerListener to PrisonPlayerListener to reduce a conflict and to make it more obvious which object is which.
For the bukkit 1.8 through bukkit 1.12, if an object has a different data value than what it normally has, it would not be matched through XMaterials… Examples are leaves, chests, etc… if there is no match initially using the block then try to then match on just the name, which eliminates the problem of a failed match.
Add a selective debug option where only the selected element is loged through the debugger.
Removed the DebugTarget value of “support” since it is not using anymore.
Bug fix: If a block has been placed in the mine that should not be there, prison was canceling the event which was preventing other plugins, or normal breakage, from breaking the block. The event is no longer being canceled.
Added 12 new placeholders: 4 new ones for player balances and 8 new ones for tokens.
Prison tokens: Added admin functions of balance, add, remove, and set.
Added the title and actionBar to the Player object so it will work in all forms of Player, such as RankPlayer. Had to use the Platform to cross over to spigot from core.
Added access to the player cache within the Player object so it’s easier to use it.
Updates some documents.
Bug fix: One of the blockEvent placeholders was inserting the wrong value. {blocksMinedTotal} was inserted the blockName.
Slight adjustment to the mine backups’s file name.
Move the messages for /mines tp to the language files.
3.2.11-alpha.9 2021-12-02 Version v3.2.11-alpha.9
Added a new feature to back up a mine and to provide a way to convert a mine to a virtual mine.
When converting to a virtual, with the command ‘/mines set area
added mine name to reset notifications
Bug fix: If a MONITOR event listener, then it should not process the block break event. Monitors were processing the block break events when they shouldn’t so monitors are not terminated after validation since their “processing” is handled there.
Bug fix: The command ‘/mines reset all details’ was not working and was only running one mine reset instead of all mines.
Rank data refactoring. A few changes to get this working. The ladderRanks collection was not being setup was the main issue.
Rank data refactoring. A few changes to get this to work well.
Major refactoring of Rank Player data objects. This is to transition to easier use of player objects in prison. Some of the key classes have been moved from Ranks module to Core module, with the removal of rank functions being moved back to the ranks module. This is a work in progress and does not yet work. The player’s ladders and ranks have not been linked together yet.
Fixed the auto sell command within the auto features to include the ability to use autosell based upon the auto features settings.
Fixed issue with a block break event happening outside of a mine, which will result in mine being null.
Fixed issue with getMine not striping color codes, but in the function before this one is called, it strips them to check to see if the mine name is valid.
3.2.11-alpha.8 2021-11-28 Release v3.2.11-alpha.8.
Update the last seen time. But will not set dirty. If player is not active, then it will not be recorded.
Expand the last seen information on the command /ranks player, which now includes how long ago instead of just a date and time.
Add a listSeenDate to the player’s cache data. This will be used to track when the player was last on, and more importantly, determine if the player’s cache data should be updated for stats reporting for top-n functions.
Fix a rare condition where the wrapper of the PrisonBlock is null (the actual bukkit block). This may not fix everything related to this issue, but it will prevent a NPE at this location.
Minor changes to clean up auto features a bit: move functions that are no longer used in the normal block break code to OnBlockBreakPlayerManualCore so it’s not confused with the main-core functions and accidentally used. Also clean up the messaging and sellall usage to eliminate duplication.
Fixed an issue with the mine state mutex being null. Not sure what’s causing it, but I suspect it mabe an issue with loading the mine from a saved state on server startup and that field never gets initialized. So fixed it by doing a lazy initialization on the field.
Fixes a minor issue with the command ‘/mines set spawn’ where it was requiring an option be specified. I fixed it by setting a default value of “set” which does nothing, but makes the optional options, optional now.
Removed from the GUI the hologram on inventory full, and replaced it with actionBar.
Some adjustments to the overflow of the drops and other inventory controls.
On normal drops, disconnected autosell except if it is forced through the pmEvent.
Fix inventory full sounds. For 1.13 and up it had the wrong sound file. Using something less harsh than anvil and turned down the volume which was horribly excessive with the volume set to 10, when normal is 1.
Prison Tokens: Prison now is able to auto generate player tokens based upon blocks mined. It’s enabled through AutoFeatures config file’s setting ‘tokensEnabled’ and is able to set the blocks per token earnings rate with ‘tokensBlocksPerToken’. More features will be added soon, such admin functions and top-n token holders…. etc…
3.2.11-alpha.7 2021-11-26 Released alpha.7. Major advancements to mine bombs.
Mine Bombs: Added the use of a armor stand for holding the item, with an animation of swirling it around. The item’s armor stand is managed in a task which removes itself when finished. This process is independent from the visual and sound effects. Removed the static functions that were being used (which is much better).
Mine Bombs: Added more effects to the examples. Removed some that would not work. These are not perfectly selected and may not work for most versions of spigot. The visual effect do not appear to really do much.
Mine Bombs: Setup some changes in how classes are related to each other so as to prepare for significant changes.
Mine Bombs: Got the sounds and visual effects hooked up to the explosions. Made many revisions on how all of this works, but pushed the tasks to a new class PrisonUtilsMinBombsTask.
Mine Bombs: Updated the listings of the mine bombs, which now includes full detail including the visual and sound effects, the list of shapes, list of sounds, and list of visual effects that can be used.
Mine Bombs: Updated the junit test for validating that the EffectState is sorted in the proper order when using the MineBombEffectsData as a comparator.
Mine Bombs: Setup a test unit test to confirm that the sorting of the EffectStates is as expected. Needs to be: placed, explode, finished.
Mine Bombs: Add the sound effects and visual effects to the default test bombs. NOTE: Some of these settings may not work on all versions of spigot, and some may not work on any version.
Bug fix: Auto features get drops not always working with explosions. The get drops was moved around to help ensure it does not try to get the block drops if the block is not what it is expected. This is now passing the needed object used for the check, instead of extracting it from the target blocks, which have not yet been set.
Bug fix: Auto Features Auto Pickup is now ignored if sellall has not been setup on the server. If getting an instance of SellAll when it is disabled, will result in a null value.
Mine Bombs: Added a few new shapes. Disk and Ring. Available in each plane x, y, and z.
Mine Bombs: Added the collections for sound effects and visual effects. Both share the same object, MineBombEffectsData. An effect has a name, plus an EffectState, and an offset in ticks that will apply that effect based upon the EffectState. The EffectState can be placed, explode, or finished.
Ran in to another Java format exception. Not sure what caused this problem, but added it to the catch so it can be reported in details so it can be fixed.
Add the ability to remove a mine’s spawn point.
Reworked how the drops were processed to prevent dropping the wrong contents. There was an issue where the drops were retrieved later in the process that allowed it to incorrectly pickup drops that were related to a decay function. This resolves the incorrect drops.
Player cache timing improvements. This fixes issues with tracking the timing when mining.
Not 100% sure it is perfect, but it’s actually working much better. Will need to revisit later.
Added a check to detect that a block has been altered and is not the block that was placed there by the mine reset. There have been drops of other materials making it in to an explosion event, and mostly due to block changes that happen due to other means.
Refactored some of the checks to determin if the event should be processed or not, so this can be used with a new feature that may help to auto manage access when WorldGuard is being used.
Setup a mutex for locking the mine resets, which prevents active block break attempts, including explosions, from trying to break blocks while a mine is actively being reset. This helps to reduce the chance of hitting a concurrent modification exception.
Shut down auto manager and all auto features if the setting ‘autoManager.isAutoManagerEnabled’ is set to ‘false’ in autoFeaturesConfig.yml. If anyone wants to use prison’s block events, then they must use the auto manager.
When using autosell through auto features, if a block cannot be sold, then the block is now placed in the player’s inventory, or dropped if their inventory is full. If a block is unable to be sold, the amount returned for the item stack will be zero.
Bug Fix: There was originally a problem with applying block constraints that resulted in being unable to select a block when trying to randomly choose one.
Initially as a first quick fix was to trying to reselect a block, but if the block chances were really low, then it could still fail to select a block. Then it was attempted to select a default block, but that too failed to work, especially if there were a sizable chance for AIR, and it would fail 100% of the time if the was only one block with a very low chance. The failure was the whole mine could be filled with that one block with the very small chance.
This fix completely redesigns the block selection, by first selecting only the blocks that are valid for that level of the mine. That way, when selecting blocks where blocks should be excluded from that level, those excluded blocks are never in the selected blocks to be considered. Also if AIR is a valid option, then this new process adds an AIR block to the temporary level block list with the percent chance assigned to the air.
Overall, this is working really well now, and it actually simplifies a lot of code and reduces the amount of processing involved. This new process always selects a block on the first pass too so it never haves to try to reselect a block.
Moved the multi-column formatting of data to the class Text so it can be used in other parts of the project. It was originally created for use in /ranks player but is now extended to be usd to list the plugins within the /prison version command.
Bug fix: If player is mining outside of a mine, then don’t process anything. May want to allow prison to manage block breaks outside of mines in the future, but for now, prison is only managing mines.
3.2.11-alpha.6 2021-11-21
New feature which lists all of the Player Cache stats in the command /ranks player. This includes stats for block breaks, time spent in mines, and earnings per mine.
Capture an error within prison’s Output class when trying to log content that has an UnknownFormatConversionException error. This happens when there is a problem with text formatting characters that conflict with Java’s formating class. This tries to log the error with better details so it can be fixed and resolved where the error is happening. This does not “fix” the problem, but just better reports it so it can be identified and fixed.
Update on how prison manages the tracking of block breaks and earnings when auto features has autosell enabled.
Changes to how the event listeners are setup: reduced by 1/3rd. Used to be that all three would be set if autopickup was enabled, but now only two will be set… monitor, and then either autopickup or manual drops. This should improve performance since prison will be processing 1/3 less events.
3.2.11-alpha.5 2021-11-19
Post the alpha.5 release.
Remove the now obsolete auto features setting isAutoSellPerBlockBreaknliedEnabled. It is no longer needed since the auto features autosell per block break is now optimized and has no impact anymore. Improve the autosell integration in to the auto features for both the auto pickup and also the normal drops. Improved the debug logging to include a list of all blocks being sold, or dropped, and their quantity and value. Also the total counts too.
Bug fix with SellAll: bug in original logic where the delayed notification when initialized is losing the first amount. It now always adds the amount to the delayed queue.
Autofeatures ignore certain events to improve performance and reduce logging entries when in debug mode. Since there are multiple listeners on block break events, which monitor the same event, these changes are able to mark a specific block within the MineTargetPrisonBlock objects that will be able to pass along an “ignore” event status to the other listeners to short-circuit their processing. This is highly beneficial when using large mine bombs and the mine has blockEvents setup to perform explosions… which will help reduce a ton of “dead” events.
Auto Features Forced Auto Sell Optimization Improvement: AutoSell within auto features now only uses sellall by item stack and not the player interface that accesses all of the player’s inventories. Since the auto features items are not placed in the player’s inventories at this time in the process of auto features, there is no reason to access the player’s inventories. Selling directly reduces a lot of sellall overhead and as a result sellall is just calculating the prices. The old autosell code within autofeatures has not be removed yet, but it cannot be called anymore.
PrisonDispatchCommandTask: Removed the debug logging since it can be very numerous when used with a large mine bomb and it’s pointless since most of the block events being submitted runs in less that one millisecond. So this is just cleaning up a messy logging item.
SellAll: Setup a sellall function that will allow the selling of one ItemStack, which is not tied to any of the player’s inventories. This is used in prison’s auto features when enabling the option to auto sell on a per block break event basis. This is highly optimized and a lot faster than using the normal sellall since it does not deal with any of the player’s inventories or backpacks. This forces a delayed sold amount message since an explosion could includ many ItemStacks.
Mine bombs: Add cooldown and fuse delay to the mine bomb settings so each bomb can be customized.
Added gravity to the mine bombs too. Gravity, like glow, was added in minecraft 1.9 so older versions won’t work.
Bug fix: For TokenEnchant’s explosive event processing, need to set PrisonMinesBlockBreakEvent’s setForceIfAirBlock( true ) so the explosion event can be processed, even if the initial block has already been processed. This allows TE explosion events to work correctly now.
*Bug fix: refined the use of a few internal registers that are being used to control block break behavior, and also block counts and block events. A few of the settings were being changed in the wrong places, which was out of synch with when they should have been applied. A few of the side effects was failure of tracking block counts, block events, and handling some explosion events.
Mine Bombs: More features and fixes. Added support for radiusInner (for hollow sphere explosion shapes), removalChance (chance for block inclusion), glowing, autoSell, tool material type, tool fortune level. Added a new shape which is “cube” and hooked up sphereHollow. Hooked up cube, sphereHollow, removalChance, glowing, the specified tool in hand with the custom fortune level. Did not hook up the forced autosell yet. Fixed some issues to get things to work a little better too.
Prison Bombs: enabled the right clicking of AIR to set the bombs. If clicking air blocks, then the block tied to the event will be null (at least for spigot 1.13.x) in that case, will use the block location of the player, and then adding the player’s vector to it times three.
Fixed a bug with how the regex handles block quotes. Not only was it not working correctly for multiple block quotes, but it was incorrectly handling the tail end of the processed text and was basically doubling the text. It now works correctly, even with multiple block quotes.
Fixed an unexpected “bug” with the JumboText font for the letter Q. One section was setup to use “\Q” which is an escape character for a regex block quote. This was causing problems since it was forcing large sections of text to be ignored when translating minecraft color codes. By changing it to “\q”, a lower case Q, this eliminated the translation from making the mistake.
Bug fix: The command “/prison support submit ranks” was passing a null sender, which is valid when generated by this support tool. The fixes now works well, and treats the null basically the same as an OP’d player, or the command being ran from the console.
Bug fix. If a null message is sent to this function, it would cause a NPE. This now prevents a few failures from causing potential problems.
Fixes a concurrent modification exception when the PlayerCacheCheckTimersTask is running.
This happens rarely when a player is logging off while “trying” to process their entries; they have been removed.
So when this happens, the process retries to start over a total of 2 more times and it skips processing players that have already been processed. Any update that was skipped would be covered in the next pass with no real loss.
The use of a command placeholders for {actionBar} and {title} were added to the placeholder enumeration so they are included in the placeholders listings.
The support for these two commands were added a while ago, but because they were not added to the enum, they were not being listed in the help.
3.2.11-alpha.4 2021-11-01 Released alpha.4.
Changes to improve the way the upcoming mine bombs. They are currently non-functional.
Adjustments to get block events, such as decays, to work correctly with the new auto feature block event handlers. Block events were moved to be processed after the block is broke. Also if a block has already been processed, it now will cancel the event to prevent normal block breakage when none should happen. At this point, the new auto manager appears to be working really well.
Changed the location usage with block event placeholders, which now uses the location that is tied to the targetBlock instead of the mined block. The mined block may be null so it’s not stable.
Fixed an issue with /mines block list when an incorrect mine name is used. Now displays an error stating the name is invalid.
Starting to add some video documents for prison.
Fixed an issue with adding a non-block item to a mine. It now validates that the specified item is a block. Also if a specified block is not in a mine when trying to remove it, it will now display a message indicating that nothing was removed.
Major rewrites to how auto features work. Using the PrisonMinesBlockBreakEvent object to carry all of the various parameters that are used within the auto features code. This allowed the elimination of many functions since they have been combined together. It also allowed for more efficient handling of explosions by combining similar blocks together and processing them as a single unit, so massive explosions are handled far more efficiently. If the admin chooses to break the blocks in another thread, then handling of many blocks is optimized to reduce the overhead. The state of the blocks being broken are being tracked through the MineTargetPrisonBlock such that it’s flagged as soon as it starts to process the impacted blocks so as to prevent the same block from being processed more than once, even when there are many explosions occurring at the same time. Changes to the block (block break) has been moved out of the depths of the code, to be closer to the event handlers so it’s easier to monitor/track. Due to the many changes and major alterations to the logic, this is a work in progress and needs more testing.
Async Mine Reset performance Improvements. Adjustments were made to improve the performance of the asynch mine resets by providing the ability to fine tune the page sizes, and also provide the ability to reset more than one block in the synchronous thread at a time. This is called a slice. Measuring the actual block reset time with nanos for better resolution. MineTargetBlockKey class was relocated to allow for the use of sub listings on the synchronized block updates.
Cloning a bomb was not complete. Some details were omitted.
Fix for Potion IllegalArgumentException: Fixed an error with potions in Player inventories when using sellall sell, potions aren’t supported by now and won’t be sold, but at least it won’t break sellall anymore.
Switched prison block debugging timing to use nanoTime instead of milliseconds since milliseconds is too large of a unit.
Bug Fix: When using block constraints, there was a common situation where an AIR block was being used in the top layers because all other blocks were being rejected due to chance. Order of blocks had an impact on this error, when it shouldn’t. Now, if a block cannot be selected, the first block with no constraint issue will be used instead. Also found a bug in the applying of the chance to each block. Under some situations, the percent chance was not being reduced for a bypassed block, when it should have. This now will better select the blocks, and better preserve their intended percentage odds of being spawned.
Prison v3.2.11-alpha.3 2021-10-18
Enable the ability to choose between setting the block to air inline, or through submitting a synch task to allow the blockBreak event handler to finish quicker, which may reduce lag.
Simplified the configuration of the handling of the block break events. Instead of having a separate setting that is a boolean value that indicates it’s either enabled or disabled, these are now using the priority value of DISABLED.
Add millisecond reporting for the time it takes to handle a block break event.
3.2.11-alpha.2 2021-10-14
A few updates to mine bombs. They have been disabled so they cannot be used.
Add the ability to glow the prison bombs when they are dropped/set.
For a couple of rankup messages, using the rank tag now instead of the rank name.
Fixed a compatibility issue with older versions of spigot. Should have possibly use the compatibility classes, but if a method does not exist, then this will fall back on a string matching pattern.
Changed the message about worn out tool to use the SpigotPlayer’s setActionBar() function to prevent overloading console messages.
Bug fix: Logic was corrected to handle the double negative correctly. The was an issue with the /mines set area command when the mine’s area was larger than 25,000 blocks. They have to enter either “confirm” or “yes”. The bug would require them to enter both to create the mine.
Added an example of possible backpack object to the PlayerCachePlayerData object.
Adjustments to the new auto features for cancel block break events and block drops.
Removal of some auto feature commented out old code.
New auto features settings: Able to prevent event canceling and also control if the drops are cleared. This has not been tested too much, but it may help make prison more compatible with other plugins that are needing to handle the block break events.
Fortune on a tool was appearing as a negative value: -1000. Not sure how it became negative, but this will better deal with negative values.
Added a listener for PlayerInteractEvent.
Add a new feature to the PrisonSpigotAPI to allow for the creation of a new mine through the API. This could be used to generate player mines in a plot world.
Able to give players bombs, based upon the item type as defined for the bomb.
Significant progress on Prison’s Mine Bombs: Moved the mine bombs primary classes to the prison core so it’s accessible from all packages. Setup 4 default mine bombs if the commands are used and there are none defined. Setup a new /prison utils bomb commands to list all bombs and to give players bombs. These are not complete and fully tested yet.
Some initial work to setup the mine bombs configs.
Add placeholders {actionBar} and {title} to the blockEvent listing of placeholders that can be used. They are shortcuts for the new prison utils commands.
For the actionBar and title, translate the color codes so they work properly.
Hook up the auto features notification to use the new actionBar interface. This “should” prevent duplicate messages from being sent to the player while the same message is displayed in the actionbar.
Fixed an error about backpacks and lore transition: A single lore was being used for the backpacks utility, if a server was new and fresh, this would’ve been missing and an error could occur, this now got fixed with the full transition.
Full transition of all messages to the .properties lang: All messages are now on the .properties file and the old .yml one is unused from now on, you can delete it and start translating the new one. Please note that some messages may be wrong, as it’s still in a young stage and a lot of messages got transitioned.
The player cache, when being shut down ran in to a problem if the players were removed when they logged off. This function was making a new collection based upon the original player cache copy of players, of which, when a few of the players are removed, then they were resulting in nulls.
Prevented a problem when unloading players, and when a player is null. The condition that was causing a null player was that the player was unloaded when the player left the server at the same time when the server was shut down. Basically a race condition with two parallel async tasks trying to shut down the player cache object, each focusing on a different aspect (player vs. server).
Hooked up XSeries’ Titles to the compatibility class instead of using version specific code. XSeries says they support 1.8.8 through 1.17.1. Deleted the support for the Spigot110 classes since it was only to support the use of the ActionBar and also the Title, which are no longer needed for 1.10+.
Adding a player messaging component to the PlayerCache. When used, this will prevent more than one of the same messages from being displayed at the same time.
For the command /mines set area the confirmation of “yes” was setup incorrectly with being negated.
Switch over to using XSeries for the actionBar. XSeries claims it works for 1.8.8 through 1.17.1.
Moved all Lores to the new .properties Language file: Changes to the old .yml language file about Lore messages won’t take effect, only if you edit the .properties file they will.
Added the trigger “minebombs” for the utils command bombs.
Adjustments to the BlockEvents and how it handles some of the event types. Expanded and fixed some of the settings for prison’s explosions, and PE’s too. Added the ability to exclude specfic triggers.
**Updates to the Prison’s explosion event handling to correct a few problems. **
Fixed SellAll Hand not removing item: SellAll Hand didn’t work properly and got now fixed.
Initial setup of Prison’s mine bombs. Initially it will be controllable as a utils command, so random chances can be assigned to explosions.
Cleaned up some of the unused variables in the Utils titles command. There were plans for more commands, but they were eliminated. This will soon be rewritten to utilize XSeries’s classes for these display items.
Ran in to a situation where results was actually null. So this prevents a NPE.
Fixed issue with tool’s durability being cutoff right before reaching the threshold. Had to change a > to a >=.
Release the first alpha.1
Replace the block with air through a task to get it out of the auto features thread.
If the settings isPreventToolBreage is enabled, then don’t allow the tool to break.
Update some messages to be clearer as to what they are. Removed the MONITOR from auto features since they should not have the monitor setting enabled. The blockBreakEvent has the monitoring event.
Trying to fix an error related to SpigotRankManager GUI: I can’t reproduce the issue but the NPE shouldn’t give a stacktrace in the console anymore.
If the primary block was null, which it never should be, then this prevents a failure in this section of code in the OnBlockBreakEventCore.
For the initial startup air count task, which is used to “reset” the block counts on a mine. This does not change any blocks, but just finds out where the mine was when the server was last shut down. This is needed to ensure we have valid counts for the mines before the first time they are reset. The other way to update these values is to do a full mine reset which is more costly. There was an inconclusive error that just listed “null” as the error messags, without identifying the actual line number. This error catching was changed to now generate a stack trace so it can be properly fixed if it occurs in the future.
Added a few more reporting entries on the block break handling. Reporting how many blocks are being processed and if it passes the validation phase.
Some fixes for teleporting and the removal of the teleport glass block.
Updates to the PrisonEnchant’s API. Minor adjustments to work with the new API from PrisonEnchants.
Updates to async block updates. Included changes to hook up the CustomItems to work with the async updates.
Clarify some of the messages related to listing of the block events.
Added the ability to identify if a block is able to be affected by gravity. Also the mine has a global setting to identify quickly if any block is gravity affected. This will be used to alter the mine reset strategy to improve performance so as to hopefully eliminate long resets due to extensive lag from falling blocks. The idea is to get all the other blocks in to place before placing the falling blocks to ensure they are less likely to fall.
**If the Mine’s saved file data is corrupted (manually edited with incorrect data), this will prevent the mine from being loaded and will now generate an error message indicating which mine has a problem loading. It will print out the invalid data, and it will default to a value of 0.00001. The function has been updated to “properly” use the localized format, so if it saves in a non US way, then it should now be able to read it back in and parse it correctly.
If the Mine’s saved file data is corrupted (manually edited with incorrect data), this will prevent the mine from being loaded and will now generate an error message indicating which mine has a problem loading. It will print out the invalid data, and it will default to a value of 0.00001.
Checking to ensure the locations are not null when loading. There was a failure with bad data on the files system that was resulting in trying to resolve nulls to a location, which obviously cannot happen.
There was an odd situation where the player was null, when usually they never can be, so this helps prevent possible errors. The null was caused by an issue with a placeholder? Don’t really remember.
Adjustments to Prison’s TPS calculations. They were only taking the average of just two readings which was resulting in very unstable TPS values. Now 10 are being used. Enabled a new feature where the resolution can be changed from normal (a reading every tick) to high resolution (one reading every 2 ticks). When the resolution changes, the task will auto terminate and resubmit with the new settings.
**For the command /ranks autoConfigure made some adjustments to the block lists being used so the top mines have more valuable ores and blocks. There was a shortage and the wrong blocks were being used.
Fixed an auto features config setting for prison’s ExplosiveBockBreakvents priority; it was missing the word priority. Reworked some of the details on autofeatures as displayed through /prison version to update them to better reflect the correct settings and dependencies.
Fixed a problem with placeholders when using the search feature, but not supplying a player’s name.
some internal changes to improve the resets
eliminate the block access in this class since it handles everything in the submitted task. This was causing an error when it was being ran in an async thread. When the task is submitted, it is ran synchoronously so it works correctly.
Changed prison’s TPS calculation to be able to enable a high-res setting when the /mines stats is enabled.
The one problem with enabling high resolution mode is that it could show an unrealistic low TPS during a reset. The /lag command shows a much higher TPS value.
Setup up the basics for async updates.
In the code that does the update, it also now reads the block to ensure that the read and update is all done in the synch thread. Otherwise the old code would be risking chunk loading in an async thread.
Using the Location and World to perform the async updates outside of needing access to the spigot module.
At this time, only /mines set tracer is using the new async reset.
Tweaks to the event listener dumps for block breaks. Updated the notes about prison’s listeners. PEExplosionEvent was setup with the wrong forClass name.
Setting up a new way to handle block updates in prison. Adding functions that are intended to be use while running in an async threads.
Transitioning over to the correct way to get the compatibility object. Just a few classes are using the old way, but they will be switched over when they are done with the edits.
Fixed the way some of the language files were being generated so it can include the spigot module, which makes it self-contained for actual Modules, since it’s always based upon the module name. Core and spigot are not technically modules, so they have special setups. Changed the Module folder from dataFolder to moduleDataFolder so it would not conflict with the SpigotPrison object.
Fixed a problem with Prison’s ExplosiveBlockBreakHandler in that it has a typo in the getHandlerList() and was not included with the registration processes. It also needed to be included with the generation of the listener dumps.
Added /sellall hand command.
Minor changes to SellAll Util.
Much better performance for SellAll generally.
SellAll Commands internal changes.
Minor changes to GUIs: Some fixes and visual changes.